Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package configuration parameters #119

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Improve package configuration parameters #119

merged 2 commits into from
Jun 19, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Jun 18, 2024

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3eab97b) to head (305b60f).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #119   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        88        88           
===========================================
  Files              9         9           
  Lines            256       256           
===========================================
  Hits             256       256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:code review The pull request needs review. label Jun 18, 2024
@vjik vjik requested a review from a team June 18, 2024 07:57
src/ViewRenderer.php Outdated Show resolved Hide resolved
Co-authored-by: Alexander Makarov <[email protected]>
@vjik vjik merged commit 2b194d5 into master Jun 19, 2024
22 of 23 checks passed
@vjik vjik deleted the improve-config branch June 19, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants