Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #131: Regex correction for table name #132

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ahmadasjad
Copy link
Contributor

Fixes #131

validates table names (letters, digits, underscore)

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

Fixes 131

validates table names (letters, digits, underscore)
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.73%. Comparing base (9ba020a) to head (b185e79).
Report is 10 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #132      +/-   ##
============================================
+ Coverage     39.63%   39.73%   +0.10%     
  Complexity      226      226              
============================================
  Files            33       34       +1     
  Lines           873      838      -35     
============================================
- Hits            346      333      -13     
+ Misses          527      505      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark changed the title Regex correction for table name Fix #131: Regex correction for table name Sep 9, 2024
@samdark samdark merged commit ca67155 into yiisoft:master Sep 9, 2024
7 of 11 checks passed
@samdark
Copy link
Member

samdark commented Sep 9, 2024

Thank you!

@ahmadasjad ahmadasjad deleted the tableNameRegexCorrection branch September 10, 2024 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect regex for ActiveRecord -> tableName
2 participants