Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #218: Add ability to set page size #219

Merged
merged 20 commits into from
Nov 22, 2024
Merged

Fix #218: Add ability to set page size #219

merged 20 commits into from
Nov 22, 2024

Conversation

samdark
Copy link
Member

@samdark samdark commented Sep 29, 2024

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌

@samdark
Copy link
Member Author

samdark commented Sep 29, 2024 •
edited
Loading

TODO:

  • Is it correct place to implement it?
  • Implement URL generation and UI.
  • Add tests.

@samdark samdark linked an issue Oct 17, 2024 that may be closed by this pull request
Add pageSizeConstraint option to BaseListView #218
Closed
@samdark samdark requested a review from vjik October 17, 2024 21:37
@vjik vjik added the status:code review The pull request needs review. label Nov 19, 2024
@vjik vjik self-assigned this Nov 19, 2024
@vjik vjik added status:under development Someone is working on a pull request. and removed status:code review The pull request needs review. labels Nov 19, 2024
@vjik vjik marked this pull request as ready for review November 22, 2024 12:06
@vjik vjik requested a review from a team November 22, 2024 12:06
@vjik vjik added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Nov 22, 2024
@vjik vjik merged commit c11a1d2 into master Nov 22, 2024
16 checks passed
@vjik vjik deleted the 218-ability-to-set-page-size branch November 22, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik Awaiting requested review from vjik

Assignees

@vjik vjik

Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pageSizeConstraint option to BaseListView
3 participants
@samdark @vjik @StyleCIBot