Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out setting of validation rules enricher from theme container #351

Merged
merged 8 commits into from
Jul 15, 2024
Merged

Move out setting of validation rules enricher from theme container #351

merged 8 commits into from
Jul 15, 2024

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌

@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8849b05) to head (741f374).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##              master      #351   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       770       771    +1     
===========================================
  Files             47        47           
  Lines           2501      2537   +36     
===========================================
+ Hits            2501      2537   +36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev requested a review from a team July 11, 2024 13:41
@arogachev arogachev self-assigned this Jul 11, 2024
@arogachev arogachev added type:task Task status:code review The pull request needs review. labels Jul 11, 2024
@arogachev arogachev linked an issue Jul 11, 2024 that may be closed by this pull request
Replace in fields ThemeContainer::getValidationRulesEnrichment() usage to method validationRulesEnricher() #344
Closed
@arogachev
Use infection directly, fix mutants (#352)
42254a6 
* Use infection directly

* Fix mutants for non existing method

* Fix mutants for non existing method 2

* Revert "Fix mutants for non existing method 2"

This reverts commit 2026b44.

* Fix

* Fix 2

* Test immutability
vjik
vjik requested changes Jul 12, 2024
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need way to globally set enricher.

@arogachev arogachev requested a review from vjik July 14, 2024 09:33
@arogachev
Copy link
Contributor Author

@vjik Added support to set enricher globally via theme.

@arogachev arogachev requested review from samdark and a team July 14, 2024 09:33
vjik
vjik approved these changes Jul 14, 2024
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove validationRulesEnricher from ThemeContainer docs.

@arogachev arogachev merged commit 4d7acc9 into master Jul 15, 2024
2 checks passed
@arogachev arogachev deleted the 344-enricher-field branch July 15, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik approved these changes

@samdark samdark samdark approved these changes

Assignees

@arogachev arogachev

Labels
status:code review The pull request needs review. type:task Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace in fields ThemeContainer::getValidationRulesEnrichment() usage to method validationRulesEnricher()
4 participants
@arogachev @samdark @vjik @StyleCIBot