Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename setInputId() method #348

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Rename setInputId() method #348

merged 1 commit into from
Jul 5, 2024

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e0daafe) to head (2ce53c8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #348   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       770       770           
===========================================
  Files             47        47           
  Lines           2501      2501           
===========================================
  Hits            2501      2501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev requested a review from a team July 5, 2024 10:22
@arogachev arogachev added the status:code review The pull request needs review. label Jul 5, 2024
@arogachev arogachev self-assigned this Jul 5, 2024
@arogachev arogachev added this to the 1.0 milestone Jul 5, 2024
@arogachev arogachev linked an issue Jul 5, 2024 that may be closed by this pull request
@arogachev arogachev added the type:task Task label Jul 5, 2024
@vjik vjik changed the title Rename setInputId() method` Rename setInputId() method Jul 5, 2024
@vjik vjik merged commit 63e1eb5 into master Jul 5, 2024
18 checks passed
@vjik vjik deleted the rename-set-input-id branch July 5, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review. type:task Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename setInputId() to shouldSetInputId() in InputField
3 participants