Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to perform getBody() on response when ExceptionResponder middleware is processing #98

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 29, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Copy link

what-the-diff bot commented Jan 29, 2024

PR Summary

  • New feature to Execute 'getBody()' during Error Processing
    A new capability was introduced for handling errors more efficiently. Now, during error processing, the system can optionally perform 'getBody()' action, which essentially helps retrieve more details from the error response.

  • Update to 'ExceptionResponder' Class
    The class that is responsible for processing errors, known as 'ExceptionResponder', has been updated. A new setting, 'performGetBodyOnResponse', has been added that controls if 'getBody()' should be used during error processing. This setting can be modified when the class is being initialized.

  • Enhanced Test Coverage
    Quality assurance measures have been bolstered by adding new tests to verify the newly added feature. Also, an existing test was updated to provide a more comprehensive coverage of the software's functionality. This helps ensure that our application remains reliable and bug-free even after updating with new features.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd84094) 80.00% compared to head (6e9c077) 80.32%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
+ Coverage     80.00%   80.32%   +0.32%     
- Complexity      168      169       +1     
============================================
  Files            13       13              
  Lines           495      498       +3     
============================================
+ Hits            396      400       +4     
+ Misses           99       98       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:code review The pull request needs review. label Jan 29, 2024
src/Middleware/ExceptionResponder.php Outdated Show resolved Hide resolved
@vjik vjik merged commit 3882b7b into master Jan 30, 2024
32 checks passed
@vjik vjik deleted the get-body branch January 30, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants