Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QueryBuilderTest::testBatchInsert() #283

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Fix QueryBuilderTest::testBatchInsert() #283

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15a13a5
Fix `QueryBuilderTest::testBatchInsert()`
Tigrov Dec 6, 2023
b0319cd
Fix psalm issue
Tigrov Dec 6, 2023
00465e7
Add line to CHANGELOG.md
Tigrov Dec 7, 2023
38844f3
Update CHANGELOG.md
vjik Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Schema.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,13 +251,12 @@ protected function loadTableForeignKeys(string $tableName): array
*
* @return array Indexes for the given table.
*
* @psalm-return array|IndexConstraint[]
* @psalm-return IndexConstraint[]
*/
protected function loadTableIndexes(string $tableName): array
{
$tableIndexes = $this->loadTableConstraints($tableName, self::INDEXES);

return is_array($tableIndexes) ? $tableIndexes : [];
/** @var IndexConstraint[] */
return $this->loadTableConstraints($tableName, self::INDEXES);
}

/**
Expand Down
11 changes: 8 additions & 3 deletions tests/QueryBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,14 @@ public function testAlterColumn(): void
* @throws NotSupportedException
* @throws Throwable
*/
public function testBatchInsert(string $table, array $columns, iterable $rows, string $expected): void
{
parent::testBatchInsert($table, $columns, $rows, $expected);
public function testBatchInsert(
string $table,
array $columns,
iterable $rows,
string $expected,
array $expectedParams = [],
): void {
parent::testBatchInsert($table, $columns, $rows, $expected, $expectedParams);
}

/**
Expand Down
Loading