Fix tests

yiisoft · Feb 20, 2025 · a007860 · a007860
1 parent fe21217
commit a007860
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 5 deletions.
diff --git a/tests/ColumnTest.php b/tests/ColumnTest.php
@@ -29,10 +29,13 @@ final class ColumnTest extends AbstractColumnTest
 
     public function testPhpTypeCast(): void
     {
-        if (version_compare($this->getConnection()->getServerInfo()->getVersion(), '21', '>=')) {
+        $db = $this->getConnection();
+
+        if (version_compare($db->getServerInfo()->getVersion(), '21', '>=')) {
             $this->fixture = 'oci21.sql';
         }
 
+        $db->close();
         $db = $this->getConnection(true);
 
         $command = $db->createCommand();
@@ -78,11 +81,15 @@ public function testPhpTypeCast(): void
 
     public function testColumnInstance(): void
     {
-        if (version_compare($this->getConnection()->getServerInfo()->getVersion(), '21', '>=')) {
+        $db = $this->getConnection();
+
+        if (version_compare($db->getServerInfo()->getVersion(), '21', '>=')) {
             $this->fixture = 'oci21.sql';
         }
 
+        $db->close();
         $db = $this->getConnection(true);
+
         $schema = $db->getSchema();
         $tableSchema = $schema->getTableSchema('type');
 

diff --git a/tests/CommandTest.php b/tests/CommandTest.php
@@ -72,10 +72,14 @@ public function testBatchInsert(
         array $expectedParams = [],
         int $insertedRow = 1
     ): void {
-        if (version_compare($this->getConnection()->getServerInfo()->getVersion(), '21', '>=')) {
+        $db = $this->getConnection();
+
+        if (version_compare($db->getServerInfo()->getVersion(), '21', '>=')) {
             $this->fixture = 'oci21.sql';
         }
 
+        $db->close();
+
         parent::testBatchInsert($table, $values, $columns, $expected, $expectedParams, $insertedRow);
     }
 

diff --git a/tests/Provider/QueryBuilderProvider.php b/tests/Provider/QueryBuilderProvider.php
@@ -338,7 +338,9 @@ public static function buildColumnDefinition(): array
         $values['reference($reference)'][0] = 'number(10) REFERENCES "ref_table" ("id") ON DELETE CASCADE';
         $values['reference($referenceWithSchema)'][0] = 'number(10) REFERENCES "ref_schema"."ref_table" ("id") ON DELETE CASCADE';
 
-        if (version_compare(self::getDb()->getServerInfo()->getVersion(), '21', '>=')) {
+        $db = self::getDb();
+
+        if (version_compare($db->getServerInfo()->getVersion(), '21', '>=')) {
             $values['array()'][0] = 'json';
             $values['structured()'][0] = 'json';
             $values['json()'][0] = 'json';
@@ -362,6 +364,8 @@ public static function buildColumnDefinition(): array
             ];
         }
 
+        $db->close();
+
         return [
             ...$values,
 

diff --git a/tests/SchemaTest.php b/tests/SchemaTest.php
@@ -32,7 +32,9 @@ final class SchemaTest extends CommonSchemaTest
      */
     public function testColumns(array $columns, string $tableName = 'type'): void
     {
-        $version21 = version_compare($this->getConnection()->getServerInfo()->getVersion(), '21', '>=');
+        $db = $this->getConnection();
+        $version21 = version_compare($db->getServerInfo()->getVersion(), '21', '>=');
+        $db->close();
 
         if ($version21 && $tableName === 'type') {
             $this->fixture = 'oci21.sql';