Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In CodeIgniter3 Router class methods was changed, if CI3 is detected … #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ig0rb
Copy link

@ig0rb ig0rb commented Dec 13, 2019

In CodeIgniter3 Router class methods was changed, if CI3 is detected the new methods are used.

I created a version check method to match CI version…the new methods are used

@yidas
Copy link
Owner

yidas commented Dec 15, 2019

Hi @ig0rb ,

Could you provide the official change of CI Router class methods for our reference?

Thank you for your support

@ig0rb
Copy link
Author

ig0rb commented Dec 17, 2019

Hi,
https://codeigniter.com/user_guide/installation/upgrade_300.html?highlight=fetch_directory

In the 3.0.0 there was a retrocompatibility, now i'm using 3.2-dev and old method's was removed.

You are welcome, you did a very usefull librariy :)

@yidas
Copy link
Owner

yidas commented Dec 24, 2019

Hi @ig0rb,

Good work!

I'm considering that we can force change the fetch_directory to a new attribute which supports all version 3 series.
In this way, we can delete the CI version detection method and the IF statement.

What do you think?

@ig0rb
Copy link
Author

ig0rb commented Dec 26, 2019

yes, I agree with you

@yidas
Copy link
Owner

yidas commented Dec 27, 2019

@ig0rb

Great!

You can refer to the discussion above to re-PR, I will merge it!

@devvspl
Copy link

devvspl commented Jul 4, 2024

Hello @yidas @ig0rb I'm working on queue processing. Could you share the complete code with me ([email protected])? I'm having trouble understanding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants