Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace xml-js with fast-xml-parser #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nodaguti
Copy link

This PR migrates from xml-js to fast-xml-parser.

The motivations are:

fast-xml-parser, by contrast, has no dependencies on Node.js modules, is actively developed, and is funded by a company. I believe fast-xml-parser is more reliable and contributes improved interoperability.

I've verified that all tests are passed and a PRE ad is properly rendered on Chromium 51 in Docker and a real device when integrated with our application.

Thank you in advance for your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant