Restore local peer discovery mechanism on Android 11+ #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neilalexander are you good with this dependency? |
'github.com/wlynxg/anet' is a partial alternative implementation of the 'golang.org/x/net' module. The goal of 'anet' module is to provide workarounds of the issues golang/go#40569 and golang/go#68082 on Android 11+.
bobrofon
force-pushed
the
android-multicast
branch
from
cfb329b
to
0813897
Compare
|
It looks like bobrofon@cfb329b is no longer necessary after the link and multicast fixes were merged into version 0.5.8. At least, I cannot reproduce the livelock on multicasting stop anymore. Removed this commit from the PR. |
neilalexander
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution is bases on https://github.com/wlynxg/anet project.
github.com/wlynxg/anetis a partial alternative implementation of thegolang.org/x/netmodule. The goal ofanetmodule is to provide workarounds of the issues golang/go#40569 and golang/go#68082 on Android 11+.Tested on AOSP 13.
Resolves: #1149