Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): archive Windows artifacts with zip #502

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

yuchanns
Copy link
Collaborator

@yuchanns yuchanns commented Sep 4, 2024

Prerequisites for #483.

Also please release a new version after merging. @yetone

@yuchanns yuchanns requested a review from yetone September 4, 2024 01:53
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq

.github/workflows/release.yaml Show resolved Hide resolved
Copy link
Collaborator

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as I don't have access to Windows, but it seems correct to me 😄

@yuchanns yuchanns merged commit 3e65e7a into yetone:main Sep 4, 2024
4 checks passed
@yuchanns yuchanns deleted the ci-windows-release branch September 4, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants