Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring classes AsyncBatchDestroyJob and AsyncBatchUpdateJob #749

Merged
merged 1 commit into from
Jul 3, 2020
Merged

refactoring classes AsyncBatchDestroyJob and AsyncBatchUpdateJob #749

merged 1 commit into from
Jul 3, 2020

Conversation

Ivanov-Anton
Copy link
Collaborator

refactoring classes according to the interface ActiveJob

@Ivanov-Anton Ivanov-Anton force-pushed the job branch 3 times, most recently from 783f021 to 2fb8ca4 Compare June 30, 2020 12:29
@Ivanov-Anton Ivanov-Anton force-pushed the job branch 4 times, most recently from b9385af to 778921b Compare July 1, 2020 06:56
@Ivanov-Anton Ivanov-Anton requested a review from gigorok July 1, 2020 06:57
gigorok
gigorok reviewed Jul 1, 2020
View reviewed changes
lib/batch_jobs_log.rb Outdated Show resolved Hide resolved
@Ivanov-Anton Ivanov-Anton force-pushed the job branch 4 times, most recently from 495142b to 90c96da Compare July 1, 2020 14:14
@Fivell Fivell requested a review from senid231 July 1, 2020 15:28
senid231
senid231 requested changes Jul 2, 2020
View reviewed changes
lib/batch_jobs_log.rb Show resolved Hide resolved
@senid231
Copy link
Member

senid231 commented Jul 2, 2020

collectiveidea/delayed_job#1118

@Ivanov-Anton Ivanov-Anton requested a review from gigorok July 3, 2020 08:53
@Ivanov-Anton Ivanov-Anton requested a review from senid231 July 3, 2020 08:53
@gigorok gigorok merged commit bf4b6d5 into yeti-switch:master Jul 3, 2020
@Ivanov-Anton
refactoring classes AsyncBatchDestroyJob and AsyncBatchUpdateJob
7e11f4a 
refactoring classes according to the interface ActiveJob
@Ivanov-Anton Ivanov-Anton deleted the job branch July 16, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigorok gigorok Awaiting requested review from gigorok

@senid231 senid231 Awaiting requested review from senid231

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ivanov-Anton @senid231 @gigorok