url-param auth POC #463
Draft
url-param auth POC #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,63 @@ | |||
| (ns lrsql.auth.interceptor | |||
There was a problem hiding this comment.
interceptor i am assuming will be renamed?
| (let [lrs (:com.yetanalytics/lrs ctx) | ||
| conn (-> lrs :connection :conn-pool) | ||
| backend (:backend lrs) | ||
| input (auth-input/query-credential-by-id-input cred-id) |
There was a problem hiding this comment.
need handling for doesnt exist?
| [lrsql.util :as util] | ||
| [next.jdbc :as jdbc])) | ||
|
|
||
| (def holder (atom nil)) |
There was a problem hiding this comment.
I am failing to see the necessity of state here. Even looking at it i can't untangle why we would introduce it. We inject an interceptor, and then it modifies ctx, why are there atoms?
| @@ -14,6 +15,8 @@ | |||
| [lrsql.util.cert :as cu] | |||
| [lrsql.util.interceptor :refer [handle-json-parse-exn]])) | |||
|
|
|||
| (def holder (atom nil)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the mechanism here is a bit convoluted:
:credentialIDfrom the:paramsmap, and attaches it to a new key in the:requestmap::com.yetanalytics.url-credential-ID. This has to be done here or elselrswill throw a fitcredentialIDnot being in spec:com.yetanalytics.url-credential-IDin the:requestmap, and, if it finds it, will query for the actual creds and modify the request so it passes Basic auth. However, I now think I can move this functionality into the interceptor and avoid muddyinglrs.clj