New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Refactoring of Parser.java - srini156 #432

Open

srini156 wants to merge 1 commit into yegor256:master from srini156:master

srini156 commented Sep 28, 2016

Changes

file is made final & immutable via constructor.
Removed duplicate code between getContent() and getContentWithoutUnicode(), using lambda function to filter.
Using StringBuilder to construct file content.
saveContent method made synchronized for thread safety.

Further enhancements:

Use BufferedReader to read characters with charset.
Use BufferedWriter to write string contents to the file.
Take care of appropriate charset in saveContent.


          Quick Refactoring of Parser.java

f494847

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet