Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: s3bids deprecation #943

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

arokem
Copy link
Collaborator

@arokem arokem commented Jan 2, 2023

See #908

@36000
Copy link
Collaborator

36000 commented Jan 2, 2023

This says WIP. What else is needed to put this over the finish line?

@arokem
Copy link
Collaborator Author

arokem commented Jan 2, 2023

If you think that's a good idea, I was thinking of raising a deprecation warning whenever s3bids is imported.

Something like eca0074

@arokem
Copy link
Collaborator Author

arokem commented Jan 2, 2023

I guess we can be more precise and set ourselves a kind of deadline, by saying something like: "will be removed no later than pyAFQ 2.0", or somesuch.

@arokem
Copy link
Collaborator Author

arokem commented Jan 2, 2023

BTW: if we are punting this as far as 2.0, I think that it's fine to go ahead with the release with s3bids in it, and then add this warning in the 1.0 cycle.

This means that the warning will only be raised upon calling a
deprecated function, or initialization of a deprecated class.
@arokem arokem added this to the pyAFQ 1.2 milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants