add "GeneratedBy"s in dataset_description.json for BIDS 1.4+ compliance
#1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
reviewed
Sep 12, 2023
There was a problem hiding this comment.
We had this in a previous PR, that was eventually closed: #870. I think that we were waiting for bids-standard/pybids#864 to get merged in pybids first, but if this now works without that, I would be OK making this change now.
| "Version": pyafq_version}} | ||
| "Version": pyafq_version}, | ||
| "GeneratedBy": [{"Name": op.basename(self.afq_path), | ||
| "Version": pyafq_version}]} |
There was a problem hiding this comment.
Can you really have both of these side-by-side?
There was a problem hiding this comment.
I left the PipelineDescription for compatibility. I think it's just going to be extra and should be deleted in the near future.
arokem
reviewed
Sep 12, 2023
Comment on lines
+190
to
+192
| "Version": pyafq_version}, | ||
| "GeneratedBy": [{"Name": op.basename(self.afq_path), | ||
| "Version": pyafq_version}]} |
There was a problem hiding this comment.
Also, while we're here, could we add something like:
Suggested change
| "Version": pyafq_version}, | |
| "GeneratedBy": [{"Name": op.basename(self.afq_path), | |
| "Version": pyafq_version}]} | |
| "Version": pyafq_version}, | |
| "GeneratedBy": [{"Name": op.basename(self.afq_path), | |
| "Version": pyafq_version}], | |
| "HowToAcknowledge": "Please cite this paper: https://apertureneuro.org/article/77465-evaluating-the-reliability-of-human-brain-white-matter-tractometry"} |
arokem
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1018