Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update name and symbol #206

Merged
merged 2 commits into from
Sep 11, 2024
Merged

feat: update name and symbol #206

merged 2 commits into from
Sep 11, 2024

Conversation

Schlagonia
Copy link
Collaborator

@Schlagonia Schlagonia commented Sep 6, 2024 •
edited
Loading

Description

  • Allow Role Manager to update the name and the symbol
  • Does not emit an event
  • Should we change the salt the factory uses to not use name and symbol now?

Fixes # (issue)

Checklist

  • I have run vyper and solidity linting
  • I have run the tests on my machine
  • I have followed commitlint guidelines
  • I have rebased my changes to the latest version of the main branch

@Schlagonia Schlagonia changed the base branch from master to 3_0_3 September 6, 2024 15:13
fp-crypto
fp-crypto approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@fp-crypto fp-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just one question ...

contracts/VaultV3.vy Show resolved Hide resolved
fp-crypto
fp-crypto approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@fp-crypto fp-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, minor ick on role manager being namer

@Schlagonia Schlagonia merged commit 8b62b3f into 3_0_3 Sep 11, 2024
4 checks passed
@Schlagonia Schlagonia deleted the update_name branch September 11, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wavey0x wavey0x wavey0x approved these changes

@fp-crypto fp-crypto fp-crypto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Schlagonia @wavey0x @fp-crypto