build: auto allocate #203
Merged
build: auto allocate #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavey0x
approved these changes
Aug 25, 2024
| @@ -1048,12 +1061,14 @@ def _update_debt(strategy: address, target_debt: uint256, max_loss: uint256) -> | |||
| withdrawable: uint256 = IStrategy(strategy).convertToAssets( | |||
| IStrategy(strategy).maxRedeem(self) | |||
| ) | |||
| assert withdrawable != 0, "nothing to withdraw" | |||
There was a problem hiding this comment.
I removed the asserts when increasing debt to not revert if it cant be done. So deposits wont revert if auto allocating.
So i also removed the assert with removing debt for continuity of how the function works both ways.
Not sure if it makes sense or not TBH.
Schlagonia
force-pushed
the
auto_allocate
branch
from
6588568
to
1029901
Compare
fp-crypto
reviewed
Sep 9, 2024
|
Schlagonia
force-pushed
the
auto_allocate
branch
from
461ddad
to
89ec23b
Compare
fp-crypto
approved these changes
Sep 12, 2024
Schlagonia
force-pushed
the
auto_allocate
branch
from
acede00
to
dcf896a
Compare
Schlagonia
added a commit
that referenced
this pull request
Sep 24, 2024
* chore: updgrade ape * build: allow max uint (#204) * build: allow max uint * fix: lint version * forge install: openzeppelin-contracts v4.9.5 * chore: oz sub module * forge install: tokenized-strategy v3.0.2 * test: fix foundry tests * chore: bump version * fix: workflow (#207) * chore: update wf version * chore: add statemind report * feat: update name and symbol (#206) * feat: set name and symbol * chore: spech * test: fix emergency * fix: test workflow (#208) * fix: config override * chore: manual setup * fix: requirements * fix: ape version * chore: rebase * chore: dont double pull from storage (#212) * feat: report on self (#205) * feat: report on self * chore: comment * chore: add back * build: auto allocate (#203) * build: auto allocate * build: dont revert debt increase * chore: remove decrease revert * chore: update spech * chore: spech * chore: comments * fix: event * fix: comments Co-authored-by: spalen0 <[email protected]> * feat: pack pf config (#211) * feat: pack pf config * chore: remove event * chore: formatting * test: interface updates * chore: comments * fix: deposit flow (#209) * forge install: openzeppelin-contracts v4.9.5 * chore: oz sub module * test: fix foundry tests * fix: deposit flow * fix: zero total assets * fix: flow * test: full loss * chore: comment * test: add invariants * fix: comments * fix: user msg sender * fix: comments * fix: comment * chore: add to interfaces * fix: comments * chore: match gov abi (#213) * chore: deployment * chore: deployed --------- Co-authored-by: FP <[email protected]> Co-authored-by: spalen0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
auto_allocateflag to the be set by the DEBT_MANAGER to automatically push all available debt to the first strategy in the queue during every deposit and mintChecklist