feat: minor fixes #194
Merged
feat: minor fixes #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wavey0x
approved these changes
Feb 1, 2024
Schlagonia
added a commit
that referenced
this pull request
Feb 5, 2024
* feat: update api and ape version * chore: removals (#189) * chore: remove increase and decrease allowances * chore: remove open roles * feat: add max loss to debt updates (#190) * feat: use cloning for vaults (#191) * feat: use cloning for vaults * fix: scripts * chore: fix interfaces * chore: lower case factory * fix: update to strategy changes * feat: add to queue flag (#195) * fix: updated strategy branch * feat: minor fixes (#194) * fix: redeem corrections * chore: dont burn zero shares * fix: use updated strategy storage * fix: rebase * chore: bump oz version * fix: oz 4626 fix * fix: lossy test * fix: round down in max redeem * fix: comment * chore: ignore snapshot * test: add foundry tests (#196) * chore: setup foundry test * chore: add remappings * forge install: erc4626-tests * test: add foundry fuzzing tests * fix: max uint deposit limit * fix: test strategy * fix: foundry runner * fix: clamp overflow * fix: default tests * chore: clean up linting * fix: new strategy version * fix: reporting costs (#192) * test: for no locking * chore: cheaper reports * chore: track current debt * chore: lower unlocked gas * fix: set to 0 * build: only burn or mint (#193) * build: only burn or mint * build: target end supply * chore: comments * fix: comments * fix: strategy changes * chore: rebase * fix: decimal type * chore: deployment and interfaces * fix: black * chore: updated strategy branch * fix: foundry remapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will round down instead of up. Eliminating a potential issue caused by double rounding in which the convertToAssets in redeem will return a value slightly higher than the max_withdraw
Checklist