fix: deposit flow #103
Merged
fix: deposit flow #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fp-crypto
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
LGTM, but probably should be gated on yearn/yearn-vaults-v3#209
spalen0
approved these changes
Sep 17, 2024
src/test/Accounting.t.sol
Outdated
| setFees(0, 0); | ||
| mintAndDepositIntoStrategy(strategy, _address, _amount); | ||
|
|
||
| uint256 toLoose = _amount; |
There was a problem hiding this comment.
Did you mean toLose? The amount that will be lost -> amount to lose?
Schlagonia
added a commit
that referenced
this pull request
Sep 24, 2024
* chore: bump api version * test: fix invariant test * feat: max deposit (#99) * feat: max uint deposit * fix: invariant test * fix: rebase * fix: dont max mint * fix: uint 256 Co-authored-by: FP <[email protected]> * fix: uint 256 Co-authored-by: FP <[email protected]> * test: check balances --------- Co-authored-by: FP <[email protected]> * chore: add statemind audit * chore: match abis (#100) * feat: update name (#101) * chore: update domain separator (#102) * chore: update domain seperator * feat: dont cache domain * chore: test runs * fix: comment Co-authored-by: spalen0 <[email protected]> * fix: comment Co-authored-by: spalen0 <[email protected]> * fix: permit cast (#104) * fix: deposit flow (#103) * fix: conversion * test: full loss * feat: add self check to max views * test: balance check * fix: spelling * chore: deployed --------- Co-authored-by: FP <[email protected]> Co-authored-by: spalen0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Still allow deposits to work if totalSupply == 0 but totalAssets > 0. Just make PPS == 1.
This can happen due to the profit unlocking if all shares are redeemed while some profit is still unlocking, at the end of the unlock time totalAssets >0 but totalSupply == 0.
Still return 0 in convertToShares if totalSupply > 0 but totalAssets == 0. Meaning a full loss.
Optimize to not cache totalAssets_ until needed
Add the check for share receiver to the maxDeposit/maxMint checks instead. So that the view functions are more accurate.
Update the variable name from
owner=>receiverto be more accurateFixes # (issue)
Checklist