Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Parse and pass streamlookup parameters #10381

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[RFC] Parse and pass streamlookup parameters #10381

wants to merge 8 commits into from
+163 −58

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Oct 14, 2024

Changelog entry

...

Changelog category

  • Improvement
  • Not for changelog (changelog entry is not required)

Additional information

...

@yumkam yumkam requested a review from nepal October 14, 2024 09:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 09:08:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for a44140e has started.
⚪ 2024-10-14 09:08:49 UTC Artifacts will be uploaded here
⚪ 2024-10-14 09:12:07 UTC ya make is running...
🔴 2024-10-14 09:15:32 UTC Build failed, see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 09:08:48 UTC Pre-commit check linux-x86_64-release-asan for a44140e has started.
⚪ 2024-10-14 09:08:59 UTC Artifacts will be uploaded here
⚪ 2024-10-14 09:12:17 UTC ya make is running...
🔴 2024-10-14 09:31:00 UTC Build failed, see the logs.

@yumkam yumkam force-pushed the pass-in-inputtransform-maxdelay branch from 0429190 to 5221fbf Compare October 14, 2024 09:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 09:49:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for ba6abe9 has started.
⚪ 2024-10-14 09:50:00 UTC Artifacts will be uploaded here
⚪ 2024-10-14 09:53:25 UTC ya make is running...
🟡 2024-10-14 11:30:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77839 63872 0 4 13857 106

🟢 2024-10-14 11:32:20 UTC ydbd size 2.8 GiB changed* by +61.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2414fb7 merge: ba6abe9 diff diff %
ydbd size 3 009 100 320 Bytes 3 009 163 200 Bytes +61.4 KiB +0.002%
ydbd stripped size 477 343 736 Bytes 477 349 624 Bytes +5.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-10-14 11:32:22 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 09:49:55 UTC Pre-commit check linux-x86_64-release-asan for ba6abe9 has started.
⚪ 2024-10-14 09:50:06 UTC Artifacts will be uploaded here
⚪ 2024-10-14 09:53:23 UTC ya make is running...
⚫ 2024-10-14 11:32:09 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 11:33:03 UTC Pre-commit check linux-x86_64-release-asan for 239fd72 has started.
⚪ 2024-10-14 11:33:06 UTC Artifacts will be uploaded here
⚪ 2024-10-14 11:36:26 UTC ya make is running...
⚫ 2024-10-14 12:19:56 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 11:34:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 239fd72 has started.
⚪ 2024-10-14 11:35:01 UTC Artifacts will be uploaded here
⚪ 2024-10-14 11:39:03 UTC ya make is running...
⚫ 2024-10-14 12:19:35 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 12:23:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1e89b80 has started.
⚪ 2024-10-14 12:24:11 UTC Artifacts will be uploaded here
⚪ 2024-10-14 12:27:28 UTC ya make is running...
🟡 2024-10-14 13:31:05 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77840 63874 0 5 13857 104

⚪ 2024-10-14 13:38:55 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-14 13:50:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
106 (only retried tests) 7 0 0 0 99

🟢 2024-10-14 13:50:21 UTC Build successful.
🟢 2024-10-14 13:50:40 UTC ydbd size 2.8 GiB changed* by +81.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b4ac18d merge: 1e89b80 diff diff %
ydbd size 3 009 371 648 Bytes 3 009 454 928 Bytes +81.3 KiB +0.003%
ydbd stripped size 477 377 272 Bytes 477 387 832 Bytes +10.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

⚪ 2024-10-14 12:24:28 UTC Pre-commit check linux-x86_64-release-asan for 1e89b80 has started.
⚪ 2024-10-14 12:24:40 UTC Artifacts will be uploaded here
⚪ 2024-10-14 12:28:07 UTC ya make is running...
🟡 2024-10-14 13:59:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14967 14543 0 84 297 43

🟢 2024-10-14 14:00:42 UTC Build successful.
🟡 2024-10-14 14:01:16 UTC ydbd size 5.7 GiB changed* by +216.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: b4ac18d merge: 1e89b80 diff diff %
ydbd size 6 096 610 408 Bytes 6 096 831 624 Bytes +216.0 KiB +0.004%
ydbd stripped size 1 520 381 136 Bytes 1 520 429 072 Bytes +46.8 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam changed the title [WIP][RFC] Parse and pass streamlookup parameters [RFC] Parse and pass streamlookup parameters Oct 14, 2024
@yumkam yumkam marked this pull request as ready for review October 14, 2024 14:46
@yumkam yumkam requested review from a team as code owners October 14, 2024 14:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

⚪ 2024-10-15 08:41:56 UTC Pre-commit check linux-x86_64-release-asan for 2c0ea3a has started.
⚪ 2024-10-15 08:44:26 UTC Artifacts will be uploaded here
⚪ 2024-10-15 08:47:47 UTC ya make is running...
🔴 2024-10-15 09:55:40 UTC Build failed, see the logs.
🟡 2024-10-15 09:56:10 UTC ydbd size 5.7 GiB changed* by +443.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6bd8708 merge: 2c0ea3a diff diff %
ydbd size 6 098 855 952 Bytes 6 099 310 256 Bytes +443.7 KiB +0.007%
ydbd stripped size 1 520 914 192 Bytes 1 521 034 064 Bytes +117.1 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

⚪ 2024-10-15 08:43:52 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2c0ea3a has started.
⚪ 2024-10-15 08:44:03 UTC Artifacts will be uploaded here
⚪ 2024-10-15 08:47:28 UTC ya make is running...
🔴 2024-10-15 09:46:01 UTC Build failed, see the logs.
🟡 2024-10-15 09:46:20 UTC ydbd size 2.8 GiB changed* by +191.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6bd8708 merge: 2c0ea3a diff diff %
ydbd size 3 010 412 920 Bytes 3 010 608 512 Bytes +191.0 KiB +0.006%
ydbd stripped size 477 518 232 Bytes 477 552 280 Bytes +33.2 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam marked this pull request as draft October 17, 2024 09:16
@yumkam yumkam force-pushed the pass-in-inputtransform-maxdelay branch from bd60070 to c124abd Compare October 18, 2024 15:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

⚪ 2024-10-18 15:17:12 UTC Pre-commit check linux-x86_64-release-asan for b0db8ec has started.
⚪ 2024-10-18 15:17:46 UTC Artifacts will be uploaded here
⚪ 2024-10-18 15:21:35 UTC ya make is running...
⚫ 2024-10-18 15:33:00 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

⚪ 2024-10-18 15:19:34 UTC Pre-commit check linux-x86_64-relwithdebinfo for b0db8ec has started.
⚪ 2024-10-18 15:19:46 UTC Artifacts will be uploaded here
⚪ 2024-10-18 15:22:52 UTC ya make is running...
🔴 2024-10-18 15:26:35 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

⚪ 2024-10-18 15:34:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for 262c091 has started.
⚪ 2024-10-18 15:35:39 UTC Artifacts will be uploaded here
⚪ 2024-10-18 15:39:22 UTC ya make is running...
⚫ 2024-10-18 15:41:54 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

⚪ 2024-10-18 15:35:19 UTC Pre-commit check linux-x86_64-release-asan for 262c091 has started.
⚪ 2024-10-18 15:35:36 UTC Artifacts will be uploaded here
⚪ 2024-10-18 15:38:43 UTC ya make is running...
⚫ 2024-10-18 15:41:55 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

⚪ 2024-10-18 15:44:09 UTC Pre-commit check linux-x86_64-release-asan for 08723cf has started.
⚪ 2024-10-18 15:44:47 UTC Artifacts will be uploaded here
⚪ 2024-10-18 15:48:36 UTC ya make is running...
🔴 2024-10-18 17:32:18 UTC Too many tests failed, NOT going to retry
🟡 2024-10-18 17:33:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14947 13956 0 660 196 135

🟢 2024-10-18 17:35:14 UTC Build successful.
🟡 2024-10-18 17:35:51 UTC ydbd size 5.7 GiB changed* by +599.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 86fa578 merge: 08723cf diff diff %
ydbd size 6 103 572 592 Bytes 6 104 186 920 Bytes +599.9 KiB +0.010%
ydbd stripped size 1 521 689 392 Bytes 1 521 814 576 Bytes +122.2 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

⚪ 2024-10-18 15:44:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 08723cf has started.
⚪ 2024-10-18 15:45:03 UTC Artifacts will be uploaded here
⚪ 2024-10-18 15:48:09 UTC ya make is running...
🔴 2024-10-18 17:09:25 UTC Too many tests failed, NOT going to retry
🔴 2024-10-18 17:14:55 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77868 61720 0 2276 13743 129

🟢 2024-10-18 17:23:06 UTC Build successful.
🟡 2024-10-18 17:23:33 UTC ydbd size 2.8 GiB changed* by +297.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 86fa578 merge: 08723cf diff diff %
ydbd size 3 012 614 232 Bytes 3 012 918 376 Bytes +297.0 KiB +0.010%
ydbd stripped size 477 673 592 Bytes 477 706 744 Bytes +32.4 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam
Copy link
Collaborator Author

yumkam commented Oct 18, 2024

Changed type for DqJoin and GraceJoinCore Flags from TCoAtomList to TCoNameValueTupleList
(this will break canonized tests)

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

⚪ 2024-10-18 18:02:15 UTC Pre-commit check linux-x86_64-release-asan for b984c63 has started.
⚪ 2024-10-18 18:02:26 UTC Artifacts will be uploaded here
⚪ 2024-10-18 18:05:39 UTC ya make is running...
🟡 2024-10-18 19:49:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14916 14698 0 57 61 100

🟢 2024-10-18 19:50:49 UTC Build successful.
🔴 2024-10-18 19:51:24 UTC ydbd size 5.7 GiB changed* by +4.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: ae2d032 merge: b984c63 diff diff %
ydbd size 6 104 555 208 Bytes 6 109 093 168 Bytes +4.3 MiB +0.074%
ydbd stripped size 1 521 873 104 Bytes 1 522 769 296 Bytes +875.2 KiB +0.059%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 18, 2024 •
edited
Loading

⚪ 2024-10-18 18:04:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for b984c63 has started.
⚪ 2024-10-18 18:04:53 UTC Artifacts will be uploaded here
⚪ 2024-10-18 18:08:05 UTC ya make is running...
🟡 2024-10-18 19:33:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77922 63882 0 33 13903 104

⚪ 2024-10-18 19:41:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-18 19:52:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
135 (only retried tests) 8 0 30 0 97

⚪ 2024-10-18 19:52:54 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-18 20:04:49 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
127 (only retried tests) 0 0 30 0 97

🟢 2024-10-18 20:04:56 UTC Build successful.
🟡 2024-10-18 20:05:21 UTC ydbd size 2.8 GiB changed* by +297.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2a74bac merge: b984c63 diff diff %
ydbd size 3 015 085 568 Bytes 3 015 389 936 Bytes +297.2 KiB +0.010%
ydbd stripped size 477 934 360 Bytes 477 967 640 Bytes +32.5 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 19, 2024 •
edited
Loading

⚪ 2024-10-19 08:22:28 UTC Pre-commit check linux-x86_64-release-asan for b16935b has started.
⚪ 2024-10-19 08:22:38 UTC Artifacts will be uploaded here
⚪ 2024-10-19 08:25:55 UTC ya make is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 19, 2024 •
edited
Loading

⚪ 2024-10-19 08:22:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for b16935b has started.
⚪ 2024-10-19 08:22:48 UTC Artifacts will be uploaded here
⚪ 2024-10-19 08:26:01 UTC ya make is running...
🟡 2024-10-19 09:40:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77919 63885 0 30 13902 102

⚪ 2024-10-19 09:48:20 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-10-19 09:59:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
131 (only retried tests) 5 0 29 0 97

⚪ 2024-10-19 09:59:57 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-10-19 10:11:27 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
126 (only retried tests) 1 0 29 0 96

🟢 2024-10-19 10:11:34 UTC Build successful.
🟡 2024-10-19 10:11:56 UTC ydbd size 2.8 GiB changed* by +297.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 07f2e60 merge: b16935b diff diff %
ydbd size 3 015 122 032 Bytes 3 015 426 392 Bytes +297.2 KiB +0.010%
ydbd stripped size 477 940 056 Bytes 477 973 336 Bytes +32.5 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nepal nepal Awaiting requested review from nepal

@zverevgeny zverevgeny Awaiting requested review from zverevgeny

@rvu1024 rvu1024 Awaiting requested review from rvu1024

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yumkam