Skip to content

Commit

Permalink
result passing: remove fill settings
Browse files Browse the repository at this point in the history
  • Loading branch information
gridnevvvit committed Oct 18, 2024
1 parent 669e2b5 commit 5eb46a5
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions ydb/core/kqp/session_actor/kqp_session_actor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,6 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
RequestCounters->TxProxyMon = MakeIntrusive<NTxProxy::TTxProxyMon>(AppData()->Counters);
CompilationCookie = std::make_shared<std::atomic<bool>>(true);

FillSettings.AllResultsBytesLimit = Nothing();
FillSettings.RowsLimitPerWrite = Config->_ResultRowsLimit.Get();
FillSettings.Format = IDataProvider::EResultFormat::Custom;
FillSettings.FormatDetails = TString(KikimrMkqlProtoFormat);
FillGUCSettings();

auto optSessionId = TryDecodeYdbSessionId(SessionId);
Expand Down Expand Up @@ -1806,7 +1802,7 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
continue;
}

TMaybe<ui64> effectiveRowsLimit = FillSettings.RowsLimitPerWrite;
TMaybe<ui64> effectiveRowsLimit = {};
if (QueryState->PreparedQuery->GetResults(i).GetRowsLimit()) {
effectiveRowsLimit = QueryState->PreparedQuery->GetResults(i).GetRowsLimit();
}
Expand Down Expand Up @@ -2564,7 +2560,6 @@ class TKqpSessionActor : public TActorBootstrapped<TKqpSessionActor> {
std::unique_ptr<TKqpCleanupCtx> CleanupCtx;
ui32 QueryId = 0;
TKikimrConfiguration::TPtr Config;
IDataProvider::TFillSettings FillSettings;
TTransactionsCache Transactions;
std::unique_ptr<TEvKqp::TEvQueryResponse> QueryResponse;
std::optional<TSessionShutdownState> ShutdownState;
Expand Down

0 comments on commit 5eb46a5

Please sign in to comment.