Added ReadRows example #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnv1
requested changes
Jul 3, 2024
| @@ -51,7 +52,12 @@ public void testReadTable() { | |||
|
|
|||
| @Test | |||
| public void testPagination() { | |||
| Assertions.assertEquals(0, PaginationApp.test(args(), "Pagination test")); | |||
| Assertions.assertEquals(0, PaginationApp.test(args()), "Pagination test"); | |||
There was a problem hiding this comment.
But you removed second argument from PaginationApp.test. Should it really be here?
Same question for testReadRows()
There was a problem hiding this comment.
This string literal is a custom message for assertion error. There was a typo when this literal was passed to PaginationApp.test(..) where it was ignored. All others methods like testBulkUpsert, testBatchUpload, testReadRows don't have this error.
There was a problem hiding this comment.
My bad, I just missed the parenthesis now moved to the left
pnv1
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.