[Hibernate 6]: Fixed the generated bool value + add test

ydb-platform · May 17, 2024 · 3d899d8 · 3d899d8
1 parent 9376490
commit 3d899d8
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 0 deletions.
diff --git a/hibernate-dialect-v5/src/test/java/tech/ydb/hibernate/types/Employee.java b/hibernate-dialect-v5/src/test/java/tech/ydb/hibernate/types/Employee.java
@@ -50,8 +50,10 @@ public class Employee {
     @Column(name = "limit_domain_password")
     private LocalDateTime limitDomainPassword;
 
+    @Column
     private byte[] bytes;
 
+    @Column
     private Enum anEnum;
 
     @Enumerated(EnumType.STRING)

diff --git a/hibernate-dialect-v5/src/test/java/tech/ydb/hibernate/types/TypesTest.java b/hibernate-dialect-v5/src/test/java/tech/ydb/hibernate/types/TypesTest.java
@@ -56,5 +56,9 @@ void integrationTypesTest() {
         employee.setActive(false);
         inTransaction(session -> session.merge(employee));
         inTransaction(session -> assertEquals(employee, session.find(Employee.class, employee.getId())));
+
+        inTransaction(session -> assertEquals(employee, session
+                .createQuery("FROM Employee e WHERE e.isActive = false", Employee.class)
+                .getSingleResult()));
     }
 }
diff --git a/hibernate-dialect/src/main/java/tech/ydb/hibernate/dialect/YdbDialect.java b/hibernate-dialect/src/main/java/tech/ydb/hibernate/dialect/YdbDialect.java
@@ -13,6 +13,7 @@
 import org.hibernate.mapping.Index;
 import org.hibernate.service.ServiceRegistry;
 import org.hibernate.sql.ast.SqlAstTranslatorFactory;
+import org.hibernate.sql.ast.spi.SqlAppender;
 import org.hibernate.tool.schema.spi.Exporter;
 import org.hibernate.type.BasicType;
 import static org.hibernate.type.SqlTypes.BIGINT;
@@ -182,6 +183,11 @@ public boolean supportsExistsInSelect() {
         return false;
     }
 
+    @Override
+    public void appendBooleanValueString(SqlAppender appender, boolean bool) {
+        appender.append(toBooleanValueString(bool));
+    }
+
     @Override
     public String toBooleanValueString(boolean bool) {
         return String.valueOf(bool);

diff --git a/hibernate-dialect/src/test/java/tech/ydb/hibernate/types/Employee.java b/hibernate-dialect/src/test/java/tech/ydb/hibernate/types/Employee.java
@@ -50,8 +50,10 @@ public class Employee {
     @Column(name = "limit_domain_password")
     private LocalDateTime limitDomainPassword;
 
+    @Column
     private byte[] bytes;
 
+    @Column
     private Enum anEnum;
 
     @Enumerated(EnumType.STRING)

diff --git a/hibernate-dialect/src/test/java/tech/ydb/hibernate/types/TypesTest.java b/hibernate-dialect/src/test/java/tech/ydb/hibernate/types/TypesTest.java
@@ -56,5 +56,9 @@ void integrationTypesTest() {
         employee.setActive(false);
         inTransaction(session -> session.merge(employee));
         inTransaction(session -> assertEquals(employee, session.find(Employee.class, employee.getId())));
+
+        inTransaction(session -> assertEquals(employee, session
+                .createQuery("FROM Employee e WHERE e.isActive = false", Employee.class)
+                .getSingleResult()));
     }
 }