feat: redesign Memory section #2618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on July 29, 2025
Learn more in the Cursor dashboard.
src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/TenantMemory.tsx
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
bugbot run |
There was a problem hiding this comment.
Pull Request Overview
This PR redesigns the Memory section in the Tenant Diagnostics Overview, modernizing the UI components and improving the visual presentation of memory usage data.
Key changes:
- Component refactoring: Replaces the old MemoryViewer with new MemoryDetailsSection and supporting components for better modularity
- Enhanced Progress visualization: Creates a new ProgressWrapper component system with support for both single and stacked progress bars
- Improved styling: Updates CSS to use design system variables and modern layouts with better spacing and typography
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils/progress.ts |
Adds new formatSegmentValue utility and improves value formatting logic |
src/containers/Tenant/Diagnostics/TenantOverview/i18n/en.json |
Adds internationalization keys for memory details section |
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/TenantStorage.tsx |
Updates to use shared ProgressWrapper component with withValue prop |
src/containers/Tenant/Diagnostics/TenantOverview/TenantStorage/ProgressWrapper.tsx |
Removes old component in favor of shared ProgressWrapper |
src/containers/Tenant/Diagnostics/TenantOverview/TenantOverview.scss |
Updates styling to use design system spacing variables |
src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/TenantMemory.tsx |
Complete redesign using new MemoryDetailsSection and MemoryProgressBar components |
src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/*.scss |
New styling files for memory components |
src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/Memory*.tsx |
New modular components for memory details, progress bars, and segment items |
src/components/ProgressWrapper/* |
New shared progress wrapper component system with types, utilities, and i18n |
src/components/MemoryViewer/utils.ts |
Adds color constants and helper functions for memory segments |
src/components/MemoryViewer/i18n/en.json |
Adds memory details internationalization key |
src/components/MemoryViewer/MemoryViewer.scss |
Updates color scheme for memory segments |
src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/TenantMemory.tsx
Outdated
Show resolved
Hide resolved
src/containers/Tenant/Diagnostics/TenantOverview/TenantMemory/MemoryDetailsSection.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2447
Stand
CI Results
Test Status: ❌ FAILED
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 85.28 MB | Main: 85.22 MB
Diff: +0.06 MB (0.07%)
ℹ️ CI Information