Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix slow requests sampling rate #2296

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix slow requests sampling rate #2296

merged 1 commit into from
Oct 16, 2024

Conversation

WilyTiger
Copy link
Collaborator

@WilyTiger WilyTiger commented Oct 16, 2024 •
edited
Loading

samplingRate was bool, and we were always getting a probability of tracing requests as 1

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 083c495.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5889 5888 0 0 0 1

@WilyTiger WilyTiger merged commit caa02b6 into main Oct 16, 2024
11 of 12 checks passed
@WilyTiger WilyTiger deleted the users/wilytiger/fix-trace branch October 16, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkrorlqr qkrorlqr qkrorlqr approved these changes

@gy2411 gy2411 gy2411 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WilyTiger @qkrorlqr @gy2411