issue-1146: enforce Clear() on all base classes for filestore transactions #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debnatkh
added
the
filestore
debnatkh
force-pushed
the
users/debnatkh/refactor-clear-in-tx
branch
4 times, most recently
from
f25e4bc
to
1a90988
Compare
debnatkh
changed the title
debnatkh
force-pushed
the
users/debnatkh/refactor-clear-in-tx
branch
from
1a90988
to
3cc5ef2
Compare
debnatkh
force-pushed
the
users/debnatkh/refactor-clear-in-tx
branch
from
3cc5ef2
to
3c1ab02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2232 (comment)
References #1146
It is necessary to implement
Clear()method for all transactions that is called upon unsuccessfulPrepareTx()because such transactions are to be restarted and we expect to read new data from the database.Earlier there transactions could be derived from
TIndexStateNodeUpdatesorTProfileAwarethat also implemented their customClear()methods and it was expected from the derived class to callClear()of the base class in itsClear()method explicitly.This leads to a possibility of forgetting to call
Clear()of the base class in the derived class. In order to fix this problem a TClearEnforcer class is introduced. It is parameterized by the derived class and the base classes.It enforces that all base classes have
DoClear()method and they all are called beforeDerived::DoClear(). Also it is enforced, that no class butTClearEnforcercan callDoClear()method ofTIndexStateNodeUpdatesandTProfileAwareclasses.