-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Disk Manager] return detailed error with aborted status on wrong etag #2248
base: main
Are you sure you want to change the base?
Conversation
fmt.Errorf(format, args...), | ||
&errors.ErrorDetails{ | ||
Code: error_codes.Aborted, | ||
Message: "data from url source changed during image creation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data from url source was changed during image creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я вот подумал, а не будет ли такое сообщение смущать пользователя -- не будет ли оно выглядеть так, будто это мы зачем-то изменили ему данные по url?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
можем тогда подробнее просто написать
can not create image because data from...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
но мне кажется что не должно возникать таких вопросов
а теста никакого на это нет? |
Есть вот такая проверка, но я не уверен, насколько она эффективно работает: https://github.com/ydb-platform/nbs/blob/main/cloud/disk_manager/internal/pkg/facade/image_service_test/image_service_test.go#L594 Подумаю, как сделать лучше |
там еще todo смущает в месте, что ты прислал. надо посмотреть что там |
Wrong ETag error occurs during creation image from url if data from source url changed during image creation. This error shoudl not be internal.