Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filestore] Implement a tool which replays filestore-vhost's profile log #2124

Open
wants to merge 57 commits into
base: main
Choose a base branch
from
Open

[Filestore] Implement a tool which replays filestore-vhost's profile log #2124

wants to merge 57 commits into from

Conversation

proller
Copy link
Contributor

@proller proller commented Sep 25, 2024

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit a79bd29.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5826 5826 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit a297662.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5805 5799 0 6 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit ff0574b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5831 5831 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 823e1b7.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5810 5804 0 6 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit d3d1f67.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5831 5831 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 472f048.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5849 5849 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 1af310a.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5850 5850 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit c2e7c5c.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5849 5849 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 262932c.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5877 5877 0 0 0 0

debnatkh
debnatkh reviewed Oct 10, 2024
View reviewed changes
cloud/filestore/tools/testing/loadtest/protos/loadtest.proto Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay.h Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay.cpp Outdated
TString filesystemId,
NProto::THeaders headers)
: Spec(std::move(spec))
, FileSystemIdRequest(std::move(filesystemId))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше унести в спеку TReplaySpec. непонятно, почему это отдельно

cloud/filestore/tools/testing/loadtest/lib/request_replay.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit a6ad099.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5878 5878 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 277106b.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5881 5881 0 0 0 0

debnatkh
debnatkh reviewed Oct 11, 2024
View reviewed changes
cloud/filestore/tools/testing/loadtest/lib/request.h Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request.h Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay.h Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/protos/loadtest.proto Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/protos/loadtest.proto Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/protos/loadtest.proto Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit bd9b7de.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5881 5881 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 134d730.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5881 5880 0 1 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 12b6349.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5882 5882 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 80f5609.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5890 5890 0 0 0 0

debnatkh
debnatkh reviewed Oct 17, 2024
View reviewed changes
cloud/filestore/tools/testing/loadtest/lib/request_replay.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
{
parent = CreateDirIfMissingByNodeLog(it->second.ParentLog);
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут не нужна проверка на то, что parent не Invalid?

cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated Show resolved Hide resolved
cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated

TString relativePathName;
if (logRequest.GetNodeInfo().GetNodeId()) {
if (auto path = PathByNode(logRequest.GetNodeInfo().GetNodeId())) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

лишний if

cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp
if (auto path = PathByNode(logRequest.GetNodeInfo().GetNodeId())) {
relativePathName = path;
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else ?

cloud/filestore/tools/testing/loadtest/lib/request_replay_fs.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit a4b51b0.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5893 5893 0 0 0 0

@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit 7a02c7e.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
5893 5893 0 0 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debnatkh debnatkh debnatkh left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proller @debnatkh