Skip to content

Commit

Permalink
add tests
Browse files Browse the repository at this point in the history
  • Loading branch information
antonmyagkov committed Oct 10, 2024
1 parent 527fccd commit 6b3bd73
Showing 1 changed file with 39 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import (
"github.com/ydb-platform/nbs/cloud/blockstore/tools/csi_driver/internal/driver/mocks"
nfs "github.com/ydb-platform/nbs/cloud/filestore/public/api/protos"
storage "github.com/ydb-platform/nbs/cloud/storage/core/protos"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
)

////////////////////////////////////////////////////////////////////////////////
Expand All @@ -24,7 +26,7 @@ func doTestCreateDeleteVolume(t *testing.T, parameters map[string]string) {
var blockSize uint32 = 4096
var blockCount uint64 = 1024

controller := newNBSServerControllerService(nbsClient, nfsClient)
controller := newNBSServerControllerService(nbsClient, nfsClient, false)

if parameters["backend"] == "nbs" {
nbsClient.On("CreateVolume", ctx, &nbs.TCreateVolumeRequest{
Expand Down Expand Up @@ -128,3 +130,39 @@ func TestGetStorageMediaKind(t *testing.T) {
)
}
}

func TestCreateVolumeFailsInVmMode(t *testing.T) {
nbsClient := mocks.NewNbsClientMock()
nfsClient := mocks.NewNfsClientMock()

ctx := context.Background()
volumeID := "test-volume-id-42"
var blockSize uint32 = 4096
var blockCount uint64 = 1024
parameters := map[string]string{
"backend": "nbs",
}

controller := newNBSServerControllerService(nbsClient, nfsClient, true)
_, err := controller.CreateVolume(ctx, &csi.CreateVolumeRequest{
Name: volumeID,
Parameters: parameters,
VolumeCapabilities: []*csi.VolumeCapability{},
CapacityRange: &csi.CapacityRange{
RequiredBytes: int64(blockCount * uint64(blockSize)),
},
})

require.Error(t, err)
status, ok := status.FromError(err)
assert.True(t, ok)
assert.Equal(t, codes.Unimplemented, status.Code())

_, err = controller.DeleteVolume(ctx, &csi.DeleteVolumeRequest{
VolumeId: volumeID,
})
require.Error(t, err)
status, ok = status.FromError(err)
assert.True(t, ok)
assert.Equal(t, codes.Unimplemented, status.Code())
}

0 comments on commit 6b3bd73

Please sign in to comment.