Improve retries

app/server/utils/retry/retry.go

@@ -33,13 +33,15 @@ func (r *retrierDefault) Run(ctx context.Context, logger *zap.Logger, op Operati
 		err := op()
 
 		if err != nil {
-			// It's convinient to disable retries for negative tests
-			if md, ok := metadata.FromIncomingContext(ctx); ok {
-				if _, exists := md[common.ForbidRetries]; exists {
+			// It's convinient to disable retries for negative tests.
+			// These tests are marked with 'ForbidRetries' flag in GRPC Metadata.
+			md, mdExists := metadata.FromIncomingContext(ctx)
+			if mdExists {
+				if _, flagSet := md[common.ForbidRetries]; flagSet {
 					logger.Warn("retriable error occurred, but 'ForbidRetries' flag was set", zap.Error(err))
-				}
 
-				return backoff.Permanent(err)
+					return backoff.Permanent(err)
+				}
 			}
 
 			// Check if error is retriable

common/consts.go

@@ -1,5 +1,5 @@
 package common
 
 const (
-	ForbidRetries = "FORBID_RETRIES"
+	ForbidRetries = "forbid_retries"
 )

tests/suite/scenario.go

@@ -51,7 +51,7 @@ func TestMissingDataSource[
 	IDBUILDER test_utils.ArrowIDBuilder[ID],
 ](s *Base[ID, IDBUILDER], dsi *api_common.TDataSourceInstance) {
 	// Do not retry negative tests
-	md := metadata.Pairs(common.ForbidRetries, "")
+	md := metadata.Pairs(common.ForbidRetries, "1")
 	ctx := metadata.NewOutgoingContext(context.Background(), md)
 
 	// read some table metadata to "heat" metrics