Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: The destroy plan fails sometimes fails in an empty state. #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jc2k
Copy link
Member

@Jc2k Jc2k commented Sep 13, 2016

Resources marked as never-destroy are 'described', but it is fatal for a thing to be described and not there. The destroy policy should always be used and it should decide not to proceed. In addition we should describe an object where possible because other resources may depend on it.

Todo:

  • This change impacts a lot of tests which are tricky to fix nicely - they use fixtures and they get their (botocore stubbed) client from the describe plan. The correct fix is probably to have a service that returns a client for a resource, rather than having a separate client for describe/destroy/apply.

Resources marked as `never-destroy` are 'described', but it is fatal for a
thing to be described and not there.

The destroy policy should **always** be used and it should decide not to
proceed.

This change impacts a lot of tests which are tricky to fix nicely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant