Skip to content

Commit

Permalink
Skip the Gradle Plugin when building with JDK 10
Browse files Browse the repository at this point in the history
Previously, the JDK 10 build would fail as we build the plugin using
Gradle 4.0.x (the lowest version of Gradle that we support) and
Gradle 4.0.x doesn't work with Java 10.

Upgrading to Gradle 4.1, which appears to work with Java 10, was
considered but rejected for now as it introduces the risk that we
inadvertently use an API that's new in 4.1 and break our 4.0 support.

This commit goes for the extreme option and disables building the
Gradle Plugin when building with JDK.

See spring-projectsgh-12028
  • Loading branch information
wilkinsona committed Mar 2, 2018
1 parent 20654b9 commit 2b1252e
Showing 1 changed file with 12 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<main.basedir>${basedir}/../../..</main.basedir>
<gradle.executable>./gradlew</gradle.executable>
<gradle.task>build</gradle.task>
<skip.gradle.build>false</skip.gradle.build>
</properties>
<dependencies>
<dependency>
Expand Down Expand Up @@ -84,6 +85,7 @@
<argument>-Pdescription=${project.description}</argument>
<argument>-S</argument>
</arguments>
<skip>${skip.gradle.build}</skip>
</configuration>
<goals>
<goal>exec</goal>
Expand Down Expand Up @@ -118,6 +120,7 @@
<classifier>sources</classifier>
</artifact>
</artifacts>
<skipAttach>${skip.gradle.build}</skipAttach>
</configuration>
</execution>
</executions>
Expand Down Expand Up @@ -302,5 +305,14 @@
</plugins>
</build>
</profile>
<profile>
<id>java10</id>
<activation>
<jdk>10</jdk>
</activation>
<properties>
<skip.gradle.build>true</skip.gradle.build>
</properties>
</profile>
</profiles>
</project>

0 comments on commit 2b1252e

Please sign in to comment.