Refactor import statements to use type declaration for better code re…

…adability and maintainability.
yasuaki640 · Jun 2, 2024 · 1f720a4 · 1f720a4
1 parent 12bec30
commit 1f720a4
Show file tree

Hide file tree

Showing 15 changed files with 22 additions and 22 deletions.
diff --git a/src/index.spec.ts b/src/index.spec.ts
@@ -1,16 +1,16 @@
 import { DrizzleD1Database } from "drizzle-orm/d1";
 import { beforeEach, describe, expect, it, vi } from "vitest";
 import app from "./index";
-import {
+import type {
   getMessagesByRoomId,
   insertMessage,
 } from "./repositories/message-repository";
 import {
   getAllRooms,
-  getRoom,
-  insertRoom,
+  type getRoom,
+  type insertRoom,
 } from "./repositories/room-repository";
-import { fetchCompletion } from "./utils/openai-client";
+import type { fetchCompletion } from "./utils/openai-client";
 
 const MOCK_BINDINGS = {
   USERNAME: "test",

diff --git a/src/index.tsx b/src/index.tsx
@@ -14,7 +14,7 @@ import {
   insertRoom,
   updateRoom,
 } from "./repositories/room-repository";
-import { Messages } from "./schema";
+import type { Messages } from "./schema";
 import type { AppEnv } from "./types";
 import { parseMarkdown } from "./utils/markdown";
 import { fetchCompletion } from "./utils/openai-client";

diff --git a/src/middleware/basic-auth.ts b/src/middleware/basic-auth.ts
@@ -1,7 +1,7 @@
 import { basicAuth } from "hono/basic-auth";
 import { createMiddleware } from "hono/factory";
 
-import { AppEnv } from "../types";
+import type { AppEnv } from "../types";
 
 export const BasicAuthMiddleware = createMiddleware<AppEnv>(async (c, next) => {
   const auth = basicAuth({

diff --git a/src/middleware/openai.ts b/src/middleware/openai.ts
@@ -1,6 +1,6 @@
 import { createMiddleware } from "hono/factory";
 import OpenAI from "openai";
-import { AppEnv } from "../types";
+import type { AppEnv } from "../types";
 
 export const OpenaiMiddleware = createMiddleware<AppEnv>(async (c, next) => {
   const client = new OpenAI({

diff --git a/src/repositories/message-repository.ts b/src/repositories/message-repository.ts
@@ -1,5 +1,5 @@
 import { eq } from "drizzle-orm";
-import { DrizzleD1Database } from "drizzle-orm/d1";
+import type { DrizzleD1Database } from "drizzle-orm/d1";
 import { Messages } from "../schema";
 
 export const insertMessage = async (

diff --git a/src/repositories/room-repository.ts b/src/repositories/room-repository.ts
@@ -1,5 +1,5 @@
 import { desc, eq } from "drizzle-orm";
-import { DrizzleD1Database } from "drizzle-orm/d1";
+import type { DrizzleD1Database } from "drizzle-orm/d1";
 import { Rooms } from "../schema";
 
 export const insertRoom = async (db: DrizzleD1Database, roomId: string) => {

diff --git a/src/types/index.d.ts b/src/types/index.d.ts
@@ -1,4 +1,4 @@
-import OpenAI from "openai";
+import type OpenAI from "openai";
 
 export type Bindings = {
   USERNAME: string;

diff --git a/src/utils/format-tilte.spec.ts b/src/utils/format-tilte.spec.ts
@@ -1,5 +1,5 @@
 import { describe, expect, it } from "vitest";
-import { Rooms } from "../schema";
+import type { Rooms } from "../schema";
 import { formatTitle } from "./format-tilte";
 
 describe("formatTitle", () => {

diff --git a/src/utils/format-tilte.ts b/src/utils/format-tilte.ts
@@ -1,4 +1,4 @@
-import { Rooms } from "../schema";
+import type { Rooms } from "../schema";
 
 export const formatTitle = (room: typeof Rooms.$inferSelect, len = 20) => {
   if (!room.roomTitle) {

diff --git a/src/utils/openai-client.ts b/src/utils/openai-client.ts
@@ -1,4 +1,4 @@
-import OpenAI from "openai";
+import type OpenAI from "openai";
 import type { ChatCompletionMessageParam } from "openai/resources";
 
 export const fetchCompletion = async (

diff --git a/src/views/Layout.tsx b/src/views/Layout.tsx
@@ -1,4 +1,4 @@
-import { FC } from "hono/dist/types/jsx";
+import type { FC } from "hono/dist/types/jsx";
 
 export const Layout: FC = ({ children }) => (
   <html lang={"ja"}>

diff --git a/src/views/NotFound.tsx b/src/views/NotFound.tsx
@@ -1,4 +1,4 @@
-import { FC } from "hono/dist/types/jsx";
+import type { FC } from "hono/dist/types/jsx";
 
 type Props = { message?: string };
 

diff --git a/src/views/Room.tsx b/src/views/Room.tsx
@@ -1,5 +1,5 @@
-import { FC } from "hono/dist/types/jsx";
-import { Messages, Rooms } from "../schema";
+import type { FC } from "hono/dist/types/jsx";
+import type { Messages, Rooms } from "../schema";
 import { formatTitle } from "../utils/format-tilte";
 
 type Props = {
@@ -30,7 +30,7 @@ export const Room: FC<{ props: Props }> = ({ props }) => (
     <hr />
     {props.message.length === 0 && <p>No messages.</p>}
     {props.message.map((message) => (
-      <div>
+      <div key={message.messageId}>
         <p>{message.messageCreated}</p>
         <p>{message.sender}</p>
         {/* biome-ignore lint: lint/security/noDangerouslySetInnerHtml */}

diff --git a/src/views/RoomList.tsx b/src/views/RoomList.tsx
@@ -1,5 +1,5 @@
-import { FC } from "hono/dist/types/jsx";
-import { Rooms } from "../schema";
+import type { FC } from "hono/dist/types/jsx";
+import type { Rooms } from "../schema";
 import { formatTitle } from "../utils/format-tilte";
 
 type Props = {
@@ -21,7 +21,7 @@ export const RoomList: FC<{ props: Props }> = ({ props }) => (
       </thead>
       <tbody>
         {props.rooms.map((room) => (
-          <tr>
+          <tr key={room.roomId}>
             <td>{formatTitle(room)}</td>
             <td>{room.roomCreated}</td>
             <td>{room.roomUpdated}</td>

diff --git a/src/views/Top.tsx b/src/views/Top.tsx
@@ -1,4 +1,4 @@
-import { FC } from "hono/dist/types/jsx";
+import type { FC } from "hono/dist/types/jsx";
 
 export const Top: FC = () => (
   <>