Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bsc#1233095 #1394

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Fix bsc#1233095 #1394

merged 2 commits into from
Nov 11, 2024

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Nov 8, 2024

Problem

There is a wrong test in which no value was passed to the #include matcher. This raises an error with rspec-expectations 3.13.2.

https://github.com/rspec/rspec-expectations/blob/838952dc1416c943e7933684c47249a77481e7f5/Changelog.md

3.13.2 / 2024-08-20
Bug Fixes:
Raise an error when passing no arguments to the include matcher. (Eric Mueller, #1479)

Solution

Fix tests by using correct data and passing a value to #include.

Testing

  • Updated unit test.

@joseivanlopez joseivanlopez marked this pull request as ready for review November 8, 2024 13:12
@coveralls
Copy link

Coverage Status

coverage: 97.814%. remained the same
when pulling d7851c2 on joseivanlopez:bsc#1233095
into 4b2d0e1 on yast:master.

Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Right, as I also found, the previous test worked with the wrong data.

@joseivanlopez joseivanlopez merged commit d63d3cd into yast:master Nov 11, 2024
7 checks passed
Copy link

✅ Autosubmission job #11775399231 successfully finished
✅ Created submit request #1223306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants