Fix nil factory #691
Merged
Fix nil factory #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Internal Jenkins job #3 successfully finished |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
insts-sys does not have sysconfig for bootloader. The code first try to get bootloader name from system and then translate it to object. Sadly that name is not checked if it is defined and it result in unnecessary error in yast logs.
Solution
Check if bootloader name is defined and if not, then just return nil to activate condition at https://github.com/yast/yast-bootloader/blob/master/src/lib/bootloader/bootloader_factory.rb#L42 to use proposed bootloader instead.
Testing
/tmp/var/log/YaST2/y2log-2.gz:2023-12-16 06:53:34 <3> install(4251) [Ruby] bootloader/bootloader_factory.rb(bootloader_by_name):84 Factory receive nil name