Updated testcases related to Origins API #2
Conversation
| case 'conda': | ||
| return `conda/${provider}` | ||
| case 'maven': | ||
| return provider === 'mavengoogle' ? provider : type |
There was a problem hiding this comment.
what about maven for mavencentral, mavengoogle and gradleplugin is the same as provider?
There was a problem hiding this comment.
case 'git':
case 'gem':
return provider
What do you think?
| it('Validates Origins API response for a Maven component with a partial group ID for suggestion checks', () => | ||
| compareOrigins(MAVEN_COMPONENT_PARTIAL_GROUP_ID)) | ||
|
|
||
| it('Validates Origins API response for a Gradle plugin component', () => |
There was a problem hiding this comment.
why do we have to separate gradle components?
There was a problem hiding this comment.
I have used separate test cases for gradle since the endpoint for it is origins/gradleplugin/:pluginID where pluginID is not consistent with the name of group id or artefact id like
Here is the case where pluginId is combination of group id and artefact id
https://plugins.gradle.org/plugin/io.outfoxx.sunday-generator
https://mvnrepository.com/artifact/io.outfoxx.sunday/generator
Here is the case where pluginId is only group id -
https://plugins.gradle.org/plugin/io.github.lognet.grpc-spring-boot
https://mvnrepository.com/artifact/io.github.lognet.grpc-spring-boot/io.github.lognet.grpc-spring-boot.gradle.plugin
Please let me know if I could handle this better. Most of the cases corresponds pluginId to group id. In that case we would also need to add another buildurl function for gradleplugin.
| assertOriginsMatch(devResponse, prodResponse) | ||
| async function compareOrigins(coordinates) { | ||
| const originUrl = coordinates.startsWith('conda/') ? buildCondaUrl(coordinates) : buildOriginUrl(coordinates) | ||
| compareEndpoints(`${originUrl}`) |
There was a problem hiding this comment.
await needs to be added
| ]) | ||
| async function compareOriginsWithRevisions(coordinates) { | ||
| const originUrl = buildOriginUrl(coordinates) | ||
| compareEndpoints(`${originUrl}/revisions`) |
There was a problem hiding this comment.
await needs to be added
No description provided.