thrift: Improve handling of enums #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| // Unknown enum | ||
| request: map[string]interface{}{ | ||
| "op": "Op(NaN)", |
|
(❤️ table test) |
| @@ -123,6 +123,15 @@ func valueFromWireMap(spec *compile.MapSpec, w wire.Map) (map[string]interface{} | |||
| return result, nil | |||
| } | |||
|
|
|||
| func mapEnumValueToName(enumSpec *compile.EnumSpec, result int32) interface{} { | |||
| for _, item := range enumSpec.Items { | |||
There was a problem hiding this comment.
Should we just setup a static mapping so we don't need to iterate like this every time?
There was a problem hiding this comment.
I think the same issue happens in code generation in thriftrw as well -- @abhinav what do you think about setting up a mapping internally in compile.EnumSpec and having a method to return the EnumItem given a value?
There was a problem hiding this comment.
We can have a reverse mapping but it will have undefined behavior when multiple enum items have the same enum value.
There was a problem hiding this comment.
Created thriftrw/thriftrw-go#134
|
LGTM with minor comments. |
When an enum value is received over the wire, it is formatted using the name. If a name is not found, it is formatted as EnumType(%d) Enums can be specified as: - int32 - Case-insentivie name - EnumType(%d) The last format is so that formatted unknown enums on the result path can be used as input.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an enum value is received over the wire, it is formatted using the
name. If a name is not found, it is formatted as EnumType(%d)
Enums can be specified as:
The last format is so that formatted unknown enums on the result path
can be used as input.