Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-build-rfc #38

Closed
wants to merge 1 commit into from
Closed

auto-build-rfc #38

wants to merge 1 commit into from

Conversation

hemanth
Copy link

@hemanth hemanth commented Dec 26, 2016

//cc @samccone @kittens

#11

@ljharb
Copy link

ljharb commented Dec 26, 2016

@hemanth if you want a postinstall script, couldn't you add one under "postinstall"?

@hemanth
Copy link
Author

hemanth commented Dec 27, 2016

Yes, that's what I meant in yarn#1416.

@Daniel15
Copy link
Member

Do any other packages automatically build when you run npm install? That feels a bit too magical for me 😛

What is the purpose of this change?

@hemanth
Copy link
Author

hemanth commented Jan 17, 2017

For making things easier with git clone and npm link.

@Daniel15
Copy link
Member

Daniel15 commented Jan 17, 2017

Sure, but what's the end goal? 😃

For a user of Yarn that wants to use the latest version, we have nightly builds available to use (https://yarnpkg.com/en/docs/nightly)
For someone building on Yarn itself, you'd need to know how to build Yarn, so I'm not sure that automating just the first build will actually help, unless people end up understanding exactly why it happens. You still need to know the build command in order to test things.

I'm not against the change at all, just curious as to its motivation.

@hemanth
Copy link
Author

hemanth commented Jan 17, 2017

I'm not against the change at all, just curious as to its motivation.

Laziness being the main motivation ;)

On a serious not, say someone is making a PR to yarn repo, if npm link does the required, it would be one step lesser and easier?

@Daniel15
Copy link
Member

say someone is making a PR to yarn repo, if npm link does the required, it would be one step lesser and easier?

For what it's worth, I don't use npm link when building on Yarn. I just run it with the exact absolute path (for example, c:\src\yarn\bin\yarn or /usr/local/src/yarn/bin/yarn). It makes it immediately obvious exactly which version of Yarn I'm running :)

@doug-wade
Copy link

doug-wade commented Feb 1, 2017

@hemanth
Why aren't we proposing use of the npm prepare script for this? It seems to me that following the npm pattern would be better for interoperability, and make this easier.

@Daniel15

Do any other packages automatically build when you run npm install?

Yes, all of them. When you run npm link, it runs the prepare script (prepublish in older npms)

@bestander
Copy link
Member

done via yarnpkg/yarn#3553

@bestander bestander closed this Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants