add prettier editor integration #1439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless @arcanis changed his mind from #12, #94, and yesterday on Discord, I don't see this getting merged. |
Ok no problem. I found it hard to contribute to the project due to lack of prettier integration (as it sounds like others did). |
|
Out of curiosity, what was difficult in particular? Prettier is made of many various rules, is there one in particular you miss? We don't have anything against automating some formatting, but we try to configure it via ESLint rather than Prettier, due to its greater flexibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Add pnp prettier support for berry development
...
How did you fix it?
Added prettier as top level dependency, ran
yarn dlx @yarnpkg/pnpify --sdk...
Checklist