Removed classic layout and ember-decorators #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Ember
5.xdeprecated the classic layout for components (with an exception for importing a classic component's layout). By moving the template files toaddon/components(I went with the default layout in Octane, which isflat), we can allow projects that depend onember-modal-dialogto updateember-sourceto6.0.0more easily.Before moving the files, I added default rendering tests for all components. These tests help us move files correctly and ensure that, when components are rendered, there will be no runtime errors.
For commits 4-5, note that, with the classic layout gone,
ember-decoratorsis only used to set a classic component'stagNameto be''. We can achieve the same effect by writingtagName = ''directly in the component class, which then lets us removeember-decoratorsas a dependency to ease maintenance.