Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listed @ember/render-modifiers as a dependency #401

Closed
wants to merge 1 commit into from
Closed

Listed @ember/render-modifiers as a dependency #401

wants to merge 1 commit into from

Conversation

ijlee2
Copy link
Collaborator

@ijlee2 ijlee2 commented Jul 16, 2024

Background

Because ember-modal-dialog uses {{did-insert}} and {{will-destroy}} modifiers, but didn't list @ember/render-modifiers as a dependency, it's possible that a consuming project can run into an error (more so, when that project lists dependencies correctly).

Here's the error message that I got from running a rendering test ([email protected] used):

Attempted to resolve `did-insert`, which was expected to be a modifier, but nothing was found.

@lukemelia
Copy link
Contributor

Addressing this via #404

@lukemelia lukemelia closed this Oct 1, 2024
@lukemelia
Copy link
Contributor

Thanks!

@ijlee2 ijlee2 deleted the bugfix-list-ember-render-modifiers-as-dependency branch October 1, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants