Listed @ember/render-modifiers as a dependency #401
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Because
ember-modal-dialog
uses{{did-insert}}
and{{will-destroy}}
modifiers, but didn't list@ember/render-modifiers
as a dependency, it's possible that a consuming project can run into an error (more so, when that project lists dependencies correctly).Here's the error message that I got from running a rendering test (
[email protected]
used):Attempted to resolve `did-insert`, which was expected to be a modifier, but nothing was found.