Skip to content

Commit

Permalink
Removed {{action}} helper from addon (#411)
Browse files Browse the repository at this point in the history
* chore: Removed {{action}} helper from addon

* chore: Removed {{action}} helper from docs-app

---------

Co-authored-by: ijlee2 <[email protected]>
  • Loading branch information
ijlee2 and ijlee2 authored Dec 6, 2024
1 parent d7c0e58 commit f0d7ba8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions addon/components/basic-dialog.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
{{#if this.hasOverlay}}
<EmberModalDialog::Overlay
class={{this.overlayClassNamesString}}
@onClickOverlay={{action
(ignore-children this.onClickOverlay)
@onClickOverlay={{ignore-children
this.onClickOverlay
}}
>
<EmberModalDialogPositionedContainer
Expand Down
4 changes: 1 addition & 3 deletions addon/components/liquid-dialog.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,7 @@
{{#if this.hasOverlay}}
<EmberModalDialog::Overlay
class={{this.overlayClassNamesString}}
@onClickOverlay={{action
(ignore-children this.onClickOverlay)
}}
@onClickOverlay={{ignore-children this.onClickOverlay}}
>
<div
class={{this.containerClassNamesString}}
Expand Down
2 changes: 1 addition & 1 deletion tests/dummy/app/utils/code-snippets/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export default class MyCoolModalDialog extends ModalDialogComponent {
}`,

'subclass-modal-dialog-animatable-hbs': `<MyCoolModalDialog
@onClose={{action "toggleSubclassed"}}
@onClose={{this.closeModal}}
@animatable={{true}}
>
<h1>Stop! Modal Time!</h1>
Expand Down

0 comments on commit f0d7ba8

Please sign in to comment.