Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] #108

Closed
wants to merge 12 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 47 additions & 3 deletions .github/workflows/package_for_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,51 @@ on:
push:

jobs:
check_issue_comment:
if: ${{ (github.event_name == 'issue_comment' && github.event.issue.pull_request && startsWith(github.event.comment.body, '/package') && contains(fromJSON('["OWNER", "COLLABORATOR"]'), github.event.comment.author_association)) }}

runs-on: ubuntu-20.04

steps:
- name: Check without commit after comment
uses: actions/github-script@v7
env:
COMMENT_ID: ${{github.event.comment.id}}
with:
script: |
const { COMMENT_ID } = process.env
let page = 1
let findComment = false
let endOfData = false
while(!endOfData) {
const { data: timelines } = await github.rest.issues.listEventsForTimeline({
owner: context.repo.owner,
repo: context.repo.repo,
page,
per_page: 100,
})
if (timelines.find(v => {
findComment = findComment || (v.event === 'commented' && `${v.id}` === `${COMMENT_ID}`)
return findComment && v.event === 'committed'
})) {
throw new Error('The commits comes after the comment.')
}
if (timelines.length === 0) {
return
}
page += 1
}

packaging:
if: ${{ (github.event_name == 'issue_comment' && github.event.issue.pull_request && startsWith(github.event.comment.body, '/package') && contains(fromJSON('["OWNER", "COLLABORATOR"]'), github.event.comment.author_association)) || github.event_name == 'push' }}
needs: [check_issue_comment]
if: ${{ (always() && needs.check_issue_comment.result == 'skipped' && github.event_name == 'push') || success() }}

strategy:
matrix:
node:
- 18.12.0
os:
- macos-latest
- ubuntu-20.04
- windows-2019

runs-on: ${{ matrix.os }}

Expand Down Expand Up @@ -45,6 +79,16 @@ jobs:
if: ${{ github.event_name == 'issue_comment' }}
with:
ref: refs/pull/${{ github.event.issue.number }}/merge

- name: Echo
run: |
echo "$COMMENT_UPDATE_AT"
echo "$ISSUE_UPDATE_AT"
echo "$TIMELINE"
env:
COMMENT_UPDATE_AT: ${{ github.event.comment.updated_at }}
ISSUE_UPDATE_AT: ${{ github.event.issue.updated_at }}
TIMELINE: ${{ github.event.issue.timeline_url }}

- name: Setup Node
uses: actions/setup-node@v4
Expand Down
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,22 @@ $ yarn
$ lerna run rebuild:nativemodules
```






#### Add CKB Indexer



CKB Indexer is a service to create cell and transaction indexes.

Download [CKB Indexer](https://github.com/nervosnetwork/ckb-indexer/releases) and move the binary into `packages/neuron-wallet/bin/{win/linux/mac}/`.

### Start Neuron


As of `v0.26.0`, Neuron bundles a CKB binary and starts it for Mainnet automatically. If you prefer to run a local CKB node yourself instead, please follow the [Nervos CKB doc](https://docs.nervos.org/docs/basics/guides/mainnet) to get it up and running before launching Neuron.

**Note**: If you run CKB node on Windows but it fails to start, you may need to download and install the latest [Microsoft Visual C++ Redistributable for Visual Studio 2015, 2017 and 2019](https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads).
Expand Down