Update yangl900/acs-engine/migration with the latest from azure/acs-engine/master #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove SPN secrets from agent node Remove the Kube Dashboard and Heapster Addons Add agentpool label on the agent nodes Use static IP address for system and agentpool1
#2) * Enable Firewall on Node, Add Windows Firewall rules for required ports * Added comments for firewall rules * Allow all traffic; lockdown kubectl Node ports to Master only * Remove & and single quote in comment section resource group deployment parser does not like these chars in the comment section
robbiezhang
reviewed
Jun 16, 2017
parts/kubernetesmastervars.t
Outdated
| @@ -184,7 +184,7 @@ | |||
| "agentWindowsPublisher": "MicrosoftWindowsServer", | |||
| "agentWindowsOffer": "WindowsServer", | |||
| "agentWindowsSku": "2016-Datacenter-with-Containers", | |||
| "agentWindowsVersion": "2016.127.20170510", | |||
| "agentWindowsVersion": "latest", | |||
There was a problem hiding this comment.
Shall we use a specific version here? @yangl900
robbiezhang
reviewed
Jun 16, 2017
parts/kubernetesmastercustomdata.yml
Outdated
|
|
||
| - path: "/etc/systemd/journald.conf.d/kubernetes.conf" |
There was a problem hiding this comment.
Why the journald is removed? How do we check the logger later?
robbiezhang
force-pushed
the
migration
branch
5 times, most recently
from
54e3bdd
to
c9d0704
Compare
wenwu449
force-pushed
the
migration
branch
2 times, most recently
from
16c28f5
to
fa3d6ff
Compare
wenwu449
force-pushed
the
migration
branch
2 times, most recently
from
21c9f3f
to
15829d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update yangl900/acs-engine/migration with the latest from azure/acs-engine/master in preparation for releasing an updated version of the Cloud Shell fork of ACS-Engine