Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use emsdk:3.1.43 not emsdk:latest #269

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Use emsdk:3.1.43 not emsdk:latest #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/make-wasm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,11 @@ jobs:

- name: docker pull
run: |
docker pull emscripten/emsdk:latest
docker pull emscripten/emsdk:3.1.43

- name: build wasm
run: |
docker run --rm -v ${PWD}/main:/src emscripten/emsdk:latest node script/wasm_build.js ${{ matrix.edition }}
docker run --rm -v ${PWD}/main:/src emscripten/emsdk:3.1.43 node script/wasm_build.js ${{ matrix.edition }}

- uses: actions/upload-artifact@v2
with:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,11 +636,11 @@ jobs:

- name: docker pull
run: |
docker pull emscripten/emsdk:latest
docker pull emscripten/emsdk:3.1.43

- name: build wasm
run: |
docker run --rm -v ${PWD}/main:/src emscripten/emsdk:latest node script/wasm_build.js ${{ matrix.edition }}
docker run --rm -v ${PWD}/main:/src emscripten/emsdk:3.1.43 node script/wasm_build.js ${{ matrix.edition }}

- uses: actions/upload-artifact@v2
with:
Expand All @@ -666,11 +666,11 @@ jobs:

- name: docker pull
run: |
docker pull emscripten/emsdk:latest
docker pull emscripten/emsdk:3.1.43

- name: build wasm
run: |
docker run --rm -v ${PWD}/main:/src emscripten/emsdk:latest node script/wasm_build.js ${{ matrix.edition }}
docker run --rm -v ${PWD}/main:/src emscripten/emsdk:3.1.43 node script/wasm_build.js ${{ matrix.edition }}

- uses: actions/upload-artifact@v2
with:
Expand All @@ -696,11 +696,11 @@ jobs:

- name: docker pull
run: |
docker pull emscripten/emsdk:latest
docker pull emscripten/emsdk:3.1.43

- name: build wasm
run: |
docker run --rm -v ${PWD}/main:/src emscripten/emsdk:latest node script/wasm_build.js ${{ matrix.edition }}
docker run --rm -v ${PWD}/main:/src emscripten/emsdk:3.1.43 node script/wasm_build.js ${{ matrix.edition }}

- uses: actions/upload-artifact@v2
with:
Expand Down
4 changes: 2 additions & 2 deletions script/wasm_build.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@echo off
cd %~dp0
cd ..
docker pull emscripten/emsdk:latest
docker run --rm -v %CD%:/src emscripten/emsdk:latest node script/wasm_build.js
docker pull emscripten/emsdk:3.1.43
docker run --rm -v %CD%:/src emscripten/emsdk:3.1.43 node script/wasm_build.js
4 changes: 2 additions & 2 deletions script/wasm_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
pushd `dirname $0`
pushd ../
docker pull emscripten/emsdk:latest
docker run --rm -v ${PWD}:/src emscripten/emsdk:latest node script/wasm_build.js
docker pull emscripten/emsdk:3.1.43
docker run --rm -v ${PWD}:/src emscripten/emsdk:3.1.43 node script/wasm_build.js
popd
popd
4 changes: 2 additions & 2 deletions script/wasm_docker_build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ if(!fs.existsSync("source/Makefile")) {
(async () => {
await new Promise((resolve) => {
let child = exec(
`docker pull emscripten/emsdk:latest`,
`docker pull emscripten/emsdk:3.1.43`,
{ cwd: cwd, stdio: "inherit" },
(_error, _stdout, _stderr) => { resolve(); },
);
Expand All @@ -23,7 +23,7 @@ if(!fs.existsSync("source/Makefile")) {
});
await new Promise((resolve) => {
let child = exec(
`docker run --rm -v ${cwd}:/src emscripten/emsdk:latest node script/wasm_build.js ${args.join(" ")}`,
`docker run --rm -v ${cwd}:/src emscripten/emsdk:3.1.43 node script/wasm_build.js ${args.join(" ")}`,
{ cwd: cwd, stdio: "inherit" },
(_error, _stdout, _stderr) => { resolve(); },
);
Expand Down
Loading