Skip to content

Commit

Permalink
Fix presets being set and state restore
Browse files Browse the repository at this point in the history
I'm not sure if preset handling will be totally correct since the
parameters would not be notifying the hosts depending on how they are
called.

`RNBO::JuceAudioProcessor::setCurrentProgram` does not set
`_isSettingPresetAsync` as far as I can tell.

This fixes the test suite referenced in Cycling74#2.

Closes Cycling74#2.

- https://github.com/Cycling74/rnbo.adapter.juce/blob/dd233609adc495828fa9efcf756ab2a155a3bd1d/RNBO_JuceAudioProcessor.cpp#L412-L421
  • Loading branch information
yamadapc committed Sep 8, 2023
1 parent dd23360 commit 9fca75e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions RNBO_JuceAudioProcessor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,9 @@ void JuceAudioProcessor::handleParameterEvent(const ParameterEvent& event)
param->setValueNotifyingHost((float)normalizedValue);
param->endChangeGesture();
}
else {
param->setValue((float)normalizedValue);
}
}
}

Expand Down

0 comments on commit 9fca75e

Please sign in to comment.