Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: CAS user email addresses not being updated on login #359

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

vinmassaro
Copy link
Contributor

@vinmassaro vinmassaro commented Jul 20, 2023

YALB-1471: Bug: CAS user email addresses not being updated on login

Description of work

  • When a user is added manually as a CAS user, a dummy email address is required to create the account. This was supposed to be updated with the user's real email address from a CAS Attribute after login, but is not working. This adds an additional configuration to use the mail CAS Attribute.
  • Also adds noreply.yale.edu as the default email hostname when creating a new user manually, so end users don't need to fill it in. The email on the user account gets updated from CAS Attributes on the user's next CAS login.

Functional testing steps:

  • Log in as user 1, create a new CAS user with your netID and set the email to [email protected]
  • In a new browser session, log in through CAS with newly created user and edit the user account, verifying the email address has been updated from [email protected]

@github-actions
Copy link

Visit Site

Created multidev environment pr-359 for yalesites-platform.

Copy link
Contributor

@nJim nJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. This works for me. I wonder if we should set these as install-configs in the yale_cas module. Would be good for other's who want to use this service.

@nJim nJim merged commit 4d4a97a into develop Jul 31, 2023
3 checks passed
@nJim nJim deleted the YALB-1471-cas-email branch July 31, 2023 03:18
@nJim nJim mentioned this pull request Jul 31, 2023
@nJim nJim mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants