-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YALB-1164 - OPAC: Update admin toolbar icons | 1461 - OPAC: Implement new admin colors and fonts #358
Conversation
Created multidev environment pr-358 for yalesites-platform. |
@miketullo95 I pushed a fix up for the text issue on blocks, as you pointed out, and some additional fixes for the content creation pages. I'm going to keep testing and fixing things locally, but please continue outlining anything else you notice. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. I'll let the others weigh in on contrast and the like, but I am not noticing any major issues.
@miketullo95 Thank you! This should be ready for a retest. Each item you referenced should be fixed (including the wool background change in layout-builder). https://pr-358-yalesites-platform.pantheonsite.io 👍 |
@miketullo95 Apologies, please hold off testing. I just saw one more item. I'll keep you posted. Thanks! |
@miketullo95 Okay, this should be ready to test again. Please make sure to add/edit layout-builder content and make sure text renders as it should. |
@miketullo95 Awesome, thank you so much! I pushed up fixes for each item. Could you please give this another look? Thank you! |
@miketullo95 Are you saying that you'd like it to look something like this? If this looks good I can double-check anywhere else (in our overrides) that may be using |
@joetower yeah, that looks great! And I think that is the last of my findings. After this change, this is approved from me 👍 |
@miketullo95 Okay, this should be ready for another look. Thank you for all your testing on this. It's a big change. 👍 |
@miketullo95 Whoops! Looks like some overrides got removed. I added them back and things should be looking correct again. Apologies for that. |
no worries, this looks great! amazing work |
YALB-1164 - OPAC: Update admin toolbar icons | YALB-1461 - OPAC: Implement new admin colors and fonts
Description of work
Functional testing steps:
Testing: YALB-1164 - OPAC: Update admin toolbar icons
unpublish
andpublish
button - note the icons change color. I used very slightly tintedgreen
andred
color values as more saturated colors would cause contrast issues.yalb-1164-icons.mp4
Testing: YALB-1461 - OPAC: Implement new admin colors and fonts
yalb-1461-admin2.mp4
yalb-1461.mp4